Thresholds for clustering with correlation-based metrics are now comp…

…uted correctly
alexzwanenburg · Sep 21, 2024 · cca5399 · cca5399
1 parent cc63d70
commit cca5399
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -20,6 +20,8 @@
 
 - The main panel for composite plots (e.g. calibration plots, Kaplan-Meier curves) is no longer of fixed width when title or subtitles are present.
 
+- Thresholds for clustering with correlation-based metrics are now computed correctly.
+
 # Version 1.4.8 (Valorous Viper)
 
 ## Bug fixes

diff --git a/R/PairwiseSimilarity.R b/R/PairwiseSimilarity.R
@@ -1209,7 +1209,7 @@ get_similarity_range <- function(similarity_metric, as_distance = FALSE) {
     value_range <- sort(unique(value_range))
   }
 
-  return(object@range)
+  return(value_range)
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         value_range <- sort(unique(value_range))
       }
-      return(object@range)
+      return(value_range)
     }
@@ Expand Down @@