Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override -> overwrite #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

override -> overwrite #2

wants to merge 6 commits into from

Conversation

srlehn
Copy link
Contributor

@srlehn srlehn commented Apr 20, 2020 •
edited
Loading

I think overwrite is meant instead of override.

https://english.stackexchange.com/a/88403

the other pull request is accidentally included...

@srlehn
Copy link
Contributor Author

srlehn commented Apr 20, 2020

if possible squash the commits...

This PR does change the API! (github.com/alexsergivan/transliterator.Transliterator and github.com/alexsergivan/transliterator/languages.LanguageOverrides with its methods)

@alexsergivan
Copy link
Owner

Override used here in the meaning to take control over something, especially in order to change the way it operates https://dictionary.cambridge.org/dictionary/english/override
But let's see other opinions from the community.

@alexsergivan alexsergivan added the waiting for other opinions Extra attention is needed label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting for other opinions Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srlehn @alexsergivan