Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(py): updating Docker img to use py312 #235

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kiraum
Copy link
Contributor

@kiraum kiraum commented Oct 23, 2024

updating Docker img to use py312, built the image locally and tested render, serve api, serve file, everything looks fine.

@alexpovel
Copy link
Owner

Thank you!

@alexpovel
Copy link
Owner

CI is failing, whatever... will fix on main and then release.

Not sure if you had signed your commit. I rebased to fix CI, which would have invalidated it, sorry!

@alexpovel alexpovel merged commit 0a90563 into alexpovel:main Oct 23, 2024
5 of 6 checks passed
@kiraum
Copy link
Contributor Author

kiraum commented Oct 23, 2024

CI is failing, whatever... will fix on main and then release.

Not sure if you had signed your commit. I rebased to fix CI, which would have invalidated it, sorry!

I have not, thanks and sorry if missed something.

@alexpovel
Copy link
Owner

Ah no, it's just CI being CI. It wasn't broken from your changes. Just flaky :-)

@kiraum kiraum deleted the kiraum/py312 branch October 23, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants