Restore functionality for [Sequence] filters: Python 3 upgrades
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update `StringMatrix` class to store alleles as strings if passed as such fallback to using the original behaviour of `ndarray` if not a string. * add a unit test to check types set as above
* move MSF files into the unit tests data area * restore the associated .pop file and .ini file for the `sequence-nopoptests.ini`
alexlancaster
added
bug
* don't check `PYTEST_VERSION`: doesn't work on older `pytest`
* can be used globally in all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting filters Python 3
Fix
StringMatrixto store alleles as strings if they are stringsThe
directorykey for[Sequence]and[AnthonyNolan]must always be provided in the.inifile