Skip to content

Commit

Permalink
Merge pull request #18 from alexhernandezgarcia/get-rid-of-hero-and-s…
Browse files Browse the repository at this point in the history 
…implify-html

 Get rid of hero tags and simplify HTML
  • Loading branch information
@alexhernandezgarcia
alexhernandezgarcia authored Nov 17, 2024
2 parents fe847b4 + eb79448 commit 35f3958
Show file tree
Hide file tree
Showing 4 changed files with 52 additions and 68 deletions.
42 changes: 13 additions & 29 deletions _includes/footer.html
View file
Original file line number Diff line number Diff line change
@@ -1,29 +1,13 @@
<div class="hero-foot">
<footer class="footer">
<div class="container">
<div class="content has-text-centered is-size-7">
<p>
Site created by Alex Hernandez-Garcia with
<a href="https://jekyllrb.com/">jekyll</a>
and
<a href="https://bulma.io/">bulma</a>.
The original version borrowed ideas from
<a href="http://pluskid.org/">pluskid.org</a>.
You are welcome to fork
<a href="https://github.com/alexhernandezgarcia/alexhernandezgarcia.github.io">the repository of this website</a>
or
<a href="https://github.com/alexhernandezgarcia/template-personal-website">this template repository</a>
to create your own website.<br>
Creative Commons License
<a href="https://creativecommons.org/licenses/by-nc-sa/4.0/">
<i class="fab fa-creative-commons fa-{{ include.icon-size }}" aria-hidden="true"></i>
<i class="fab fa-creative-commons-by fa-{{ include.icon-size }}" aria-hidden="true"></i>
<i class="fab fa-creative-commons-nc fa-{{ include.icon-size }}" aria-hidden="true"></i>
<i class="fab fa-creative-commons-sa fa-{{ include.icon-size }}" aria-hidden="true"></i>
</a>
</p>
</div>
</div>
</footer>
</div>

<footer class="footer">
<div class="content has-text-centered is-size-7">
{% capture content %}{% include footer.md %}{% endcapture %}
{{ content | markdownify }}
<a href="https://creativecommons.org/licenses/by-nc-sa/4.0/">
<i class="fab fa-creative-commons fa-{{ include.icon-size }}" aria-hidden="true"></i>
<i class="fab fa-creative-commons-by fa-{{ include.icon-size }}" aria-hidden="true"></i>
<i class="fab fa-creative-commons-nc fa-{{ include.icon-size }}" aria-hidden="true"></i>
<i class="fab fa-creative-commons-sa fa-{{ include.icon-size }}" aria-hidden="true"></i>
</a>
Creative Commons License <a href="https://creativecommons.org/licenses/by-nc-sa/4.0/">CC BY-NC-SA 4.0</a>
</div>
</footer>
4 changes: 4 additions & 0 deletions _includes/footer.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Site created by Alex Hernandez-Garcia with [jekyll](https://jekyllrb.com/) and [bulma](https://bulma.io/).
The original version borrowed ideas from [pluskid.org](http://pluskid.org/).
You are welcome to fork [the repository of this website](https://github.com/alexhernandezgarcia/alexhernandezgarcia.github.io) or [this template repository](https://github.com/alexhernandezgarcia/template-personal-website) to create your own website.

62 changes: 30 additions & 32 deletions _includes/navigation.html
View file
Original file line number Diff line number Diff line change
@@ -1,37 +1,35 @@
<div class="hero-head">
<nav class="navbar container" role=navigation>
<div class="navbar-brand">
<a class="navbar-item" href="/">
<strong>{{ site.title }}</strong>
</a>
<div role="button" class="navbar-burger burger" aria-label="menu" aria-expanded="false" data-target="navbar-main">
<span aria-hidden="true"></span>
<span aria-hidden="true"></span>
<span aria-hidden="true"></span>
</div>
<nav class="navbar container" role=navigation>
<div class="navbar-brand">
<a class="navbar-item" href="/">
<strong>{{ site.title }}</strong>
</a>
<div role="button" class="navbar-burger burger" aria-label="menu" aria-expanded="false" data-target="navbar-main">
<span aria-hidden="true"></span>
<span aria-hidden="true"></span>
<span aria-hidden="true"></span>
</div>
<div id="navbar-main" class="navbar-menu">
<div class="navbar-start">
{% for item in site.data.navigation %}
<a class="navbar-item" href="{{ item.link }}" {% if page.url == item.link %}class="is-dark"{% endif %}>
{{ item.name }}
</div>
<div id="navbar-main" class="navbar-menu">
<div class="navbar-start">
{% for item in site.data.navigation %}
<a class="navbar-item" href="{{ item.link }}" {% if page.url == item.link %}class="is-dark"{% endif %}>
{{ item.name }}
</a>
{% endfor %}
</div>
<div class="navbar-end">
<div class="navbar-item">
{% for item in site.data.social %}
<a class="button is-text" href="{{ item.link }}" style="text-decoration: none">
<span class="icon">
<i
class="{{ item.icon.type }} {{ item.icon.name }} {{ item.icon.source }}-{{ include.icon-size }}"
aria-hidden="true">
</i>
</span>
</a>
{% endfor %}
</div>
<div class="navbar-end">
<div class="navbar-item">
{% for item in site.data.social %}
<a class="button is-text" href="{{ item.link }}" style="text-decoration: none">
<span class="icon">
<i
class="{{ item.icon.type }} {{ item.icon.name }} {{ item.icon.source }}-{{ include.icon-size }}"
aria-hidden="true">
</i>
</span>
</a>
{% endfor %}
</div>
</div>
</div>
</nav>
</div>
</div>
</nav>
12 changes: 5 additions & 7 deletions _layouts/main.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@
{% seo %}
</head>
<body>
<section class="hero is-fullheight">
{% include navigation.html icon-size="lg" %}
<div class="hero-body">
<div class="container">
{{ content }}
</div>
{% include navigation.html icon-size="lg" %}
<section class="section">
<div class="container">
{{ content }}
</div>
{% include footer.html icon-size="lg" %}
</section>
{% include footer.html icon-size="lg" %}
</body>
</html>

0 comments on commit 35f3958

Please sign in to comment.