Order query statuses #171
Closed
Order query statuses #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping fork up-to-date
|
I have tested the proposed change locally and find that it does NOT return orders of all the specified statuses. It returns the first specified status, but ignores the rest. |
|
Thanks for the feedback. I am going to take a look into this. |
|
Hey Alex,
After fuller investigation, the issue appears to be associated with the TDA
API; there does not seem to be a way to specify more than a single status.
Really unfortunate.
…On Tue, Feb 23, 2021 at 9:48 AM Ray ***@***.***> wrote:
@bob-mcrae <https://github.com/bob-mcrae>,
Thanks for the feedback. I am going to take a look into this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR6XMBX4UM72FITTQMQK5Y3TAPL7XANCNFSM4XRYRRWA>
.
|
|
Thanks for looking into this. I am going to close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
Addressing what seems to be an issue with get_orders_by_query() when using multiple order statuses. Hope this is helpful.