Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: call callback after fetching remote commands #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OvisMaximus
Copy link

The init callback has been called directly after fetching the lirc remotes. The commands of these were not available then. Fixed by collecting the execs fetching the remote commands.

Since the involved methods solely rely on output of the executed commands, i see no reasonable way to implement a test which validates the timing.

@OvisMaximus
Copy link
Author

BTW, I had three tests not working, but I have not interferred with the code they depend on:

  1) IRReceive [child process listening for input] upon receiving input should execute the callback(s) each time the input is received, if no throttle was set:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.


  2) IRReceive [child process listening for input] upon receiving input should execute the callback(s) just once while the key is held down, if throttle was set to 0:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.


  3) IRReceive [child process listening for input] upon receiving input should execute the callback(s) once every Xms while the key is held down, if throttle was set to a positive integer:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant