Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare code for WRS calls. #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

acflorea
Copy link

Added main method, prepare code for WRS calls.

@alexandrupaler
Copy link
Owner

Have a look at training.py and you can add the main method call to that file.

@acflorea
Copy link
Author

Done. TY!
There are two remaining questions in the comments.

training.py Show resolved Hide resolved
training.py Outdated Show resolved Hide resolved
@acflorea
Copy link
Author

Adjusted according to your answers. I've left the two loops in place - since we have both the optimal_depth and depth_result I feel it would make more sense to minimise their square difference - what do you think ?

Still wondering if sum or average over all results in the loop ...

@alexandrupaler
Copy link
Owner

Chose whatever you think optimises best. Square difference should be fine too. However, our values will be only on the rhs of the optimum. Because our optimum is a minimum value, all differences will be positive.

run.sh Outdated
@@ -0,0 +1,4 @@
#!/bin/bash
cd /Users/acflorea/phd/k7m/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid absolute paths related to your computer

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a folder called wrs where the scripts and code related to wrs is stored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants