Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background image stretch #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mannski
Copy link

@mannski mannski commented Oct 26, 2018

The background image is stretching (distoring) on wide screens. I've made 2 changes to common.sass to fix this:

  1. changing the body background-size to "cover"
  2. removing the background-size rule in the media query for small screens, since it is no longer necessary

Related to issue #12

I confirm:

  • I've read the contributing guidelines and the code of conduct
  • I've checked that this issue applies to this repo
  • I've checked the existing issues, no one else has reported this
  • I've limited the subject line to 50 characters
  • I've capitalised the subject line
  • I've not ended the subject line with a period
  • I've used the imperative mood in the subject line

Making an enhancement - ignore this if not making an enhancement

The background image is stretching (distoring) on wide screens. This is fixed by using background-size: cover. Works well on all screen sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant