Changed input of token values and values.yml #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed password to TAP_TOKEN changed trigger to this branch and changes values to try to get the SSM values from AWS changed other password to TAP_TOKEN changed token for the previus one, changed the deploy line to point to the ssm in aws and changed values to recieve all the information style change changed token updated publish.yml style change changed token name deleted one env added token as env value in publish.yml and modified deploy.go to original style changes changed name to lowecase in gh changed token changed TAP_TOKEN value changed TAP_TOKEN value changed username to alercebroker changed trigger to push on main branch changed trigger to push on main branch, username to alercebroker and changed tap_token value
dirodriguezm
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first problem was that the token was called in a bad way. To call tokens with dagger we must define this token as a environment variable and then call it with the defined name in the script. Also we changed valued.yml to get the AWS secrets values.
Changed trigger to push on main branch, username to alercebroker and changed tap_token value. We added an PAT value to the tap_token.