Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WalletConnect deps from 2.15.1 to 2.17.2 #478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Dec 2, 2024

I am working on improving the connectivity of our wallets to our dApps. I noticed that this update helps on the mobile wallet side. I guess it makes sense to update them in the SDK as well.

@nop33 nop33 requested a review from Lbqds December 2, 2024 15:04
@nop33
Copy link
Member Author

nop33 commented Dec 2, 2024

@h0ngcha0 I noticed that a dependency of the the npm-run-all package of the @alephium/walletconnect package had an pnpm audit issue. I completely removed this dep since it wasn't adding much value to the project. It was only used to make an npm script shorted:

//before
"build": "npm-s build:pre build:cjs build:umd",
//now
"build": "pnpm build:pre build:cjs build:umd",

@nop33 nop33 requested review from h0ngcha0 and removed request for Lbqds December 2, 2024 15:18
@polarker
Copy link
Member

@Lbqds Please help us upgrade this PR to make it ready for merging

@polarker
Copy link
Member

@Lbqds Let's create a new PR to only update the dependencies if playing with pnpm is a waste of time.

@Lbqds
Copy link
Member

Lbqds commented Dec 13, 2024

The CI has been failing after removing npm-run-all, but I can build it locally. After trying some changes, the CI still fails. I’ve created a new PR here to update WalletConnect to the latest version, and I will continue to try to fix the CI later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants