test: improved tests for packages/web3/src/address

[SoarinSkySagar]

resolves #451

[SoarinSkySagar]

@polarker @kfastov PTAL

[h0ngcha0]

Hey, thanks for the contribution.

Please make sure that the tests pass, right now several of them are failing:

> npm run test -- address.test.ts --collectCoverageOnlyFrom ''
....
Test Suites: 1 failed, 1 total
Tests:       3 failed, 36 passed, 39 total

[SoarinSkySagar]

PTAL @h0ngcha0

[SoarinSkySagar]

PTAL @h0ngcha0

[h0ngcha0]

Please run npm run lint -- --fix to fix the formatting of the updated files.

[pragmaxim]

Wouldn't it be a major improvement of these tests if the literal addresses and contractI-ids were extracted into variables of meaningful name, possibly generating them?

[SoarinSkySagar]

Wouldn't it be a major improvement of these tests if the literal addresses and contractI-ids were extracted into variables of meaningful name, possibly generating them?

I guess to generate the addresses I would need to import from @alephium/web3-wallet package, which is not possible as we're not able to import rn, as has been my conclusion from our chats on telegram group. So it has been done this way

[SoarinSkySagar]

Made all the required changes according to your reviews @h0ngcha0 ser, PTAL

[SoarinSkySagar]

Please run npm run lint -- --fix to fix the formatting of the updated files.

Umm I don't think there are any formatting errors in the updated file, just checked with the command

[pragmaxim]

I guess to generate the addresses I would need to import from @alephium/web3-wallet package, which is not possible as we're not able to import rn, as has been my conclusion from our chats on telegram group. So it has been done this way

Yes, but I noticed of same string literal to be used 5 times in the same spec which is a perfect candidate for a constant I think

[SoarinSkySagar]

Yes, but I noticed of same string literal to be used 5 times in the same spec which is a perfect candidate for a constant I think

Done, extracted all repetitive addresses and contractIds into separate variables