Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: desktop wallet on Windows while 'About' window is still open leads to a white screen #977

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: desktop wallet on Windows while 'About' window is still open leads to a white screen #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion apps/desktop-wallet/public/electron.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,19 @@ const template = [
...(isMac
? []
: isWindows
? [{ role: 'about' }, { type: 'separator' }]
? [
{
label: `About ${app.getName()}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the role: 'about' that we had before is responsible for translating the word "About" based on the user's locale...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all menu items are not translated based on user's locale @nop33

click: async () => {
dialog.showMessageBoxSync(mainWindow, {
message: `Version ${CURRENT_VERSION}`,
title: app.getName(),
type: 'info'
})
}
},
{ type: 'separator' }
]
: [
{
label: 'About',
Expand Down