Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify banxa flow using WebBrowser #1090

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Simplify banxa flow using WebBrowser #1090

merged 10 commits into from
Jan 8, 2025

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Jan 8, 2025

This PR:

  1. Simplifies BuyModal code
  2. Relies on the OS's native browser and opening a tab * within the app * (does not create a new task in the task manager - we're still in the app)
  3. Fixes rendering issues reported by testers (see below)
  4. Fixes Google Pay
  5. Adds Buy button in Receive screen and uses selected receive address
  6. Adds text below icons in dashboard card buttons
  7. Fixes loading glitches

Related website PR

Demo

Kapture.2025-01-08.at.10.43.36.mp4
image

Rendering issues

Click to see screenshots

Tab icons show at the bottom of the webview after switching between apps:

Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: f493f90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@mvaivre mvaivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!

@nop33 nop33 merged commit a761ace into next Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants