Skip to content
This repository has been archived by the owner on Apr 10, 2019. It is now read-only.

Commit

Permalink
Update install.sh + README.
Browse files Browse the repository at this point in the history
Ideally we could check in CI that the generated godownloader script
doesn't differ from script/install.sh, but godownloader is currently
broken (goreleaser/godownloader#81).

Fixes #525. Fixes #526.
  • Loading branch information
alecthomas committed Sep 6, 2018
1 parent bb55412 commit 3917f98
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
13 changes: 5 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,11 @@ It is intended for use with editor/IDE integration.

## Installing

There are two options for installing gometalinter.
To install the latest stable release:

1. Install a stable version, eg. `go get -u gopkg.in/alecthomas/gometalinter.v2`.
I will generally only tag a new stable version when it has passed the Travis
regression tests. The downside is that the binary will be called `gometalinter.v2`.
2. Install from HEAD with: `go get -u github.com/alecthomas/gometalinter`.
This has the downside that changes to gometalinter may break.
curl https://git.io/vp6lP | sh

Alternatively you can install a specific version from the [releases](https://github.com/alecthomas/gometalinter/releases) list.

## Editor integration

Expand Down Expand Up @@ -334,8 +332,7 @@ are three things to try in that case:
#### 1. Update to the latest build of gometalinter and all linters
go get -u github.com/alecthomas/gometalinter
gometalinter --install
curl https://git.io/vp6lP | sh
If you're lucky, this will fix the problem.
Expand Down
4 changes: 2 additions & 2 deletions scripts/install.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
set -e
# Code generated by godownloader on 2018-05-08T08:53:30Z. DO NOT EDIT.
# Code generated by godownloader on 2018-09-06T00:26:55Z. DO NOT EDIT.
#

usage() {
Expand Down Expand Up @@ -51,7 +51,7 @@ execute() {
rm -rf "${srcdir}"
(cd "${tmpdir}" && untar "${TARBALL}")
install -d "${BINDIR}"
for binexe in "gometalinter" "gocyclo" "nakedret" "misspell" "govet" "gosec" "golint" "ineffassign" "goconst" "errcheck" "maligned" "unconvert" "dupl" "structcheck" "varcheck" "safesql" "deadcode" "lll" "goimports" "gotype" "gosimple" "megacheck" "staticcheck" "unused" "interfacer" "unparam" ; do
for binexe in "gometalinter" "gocyclo" "nakedret" "misspell" "gosec" "golint" "ineffassign" "goconst" "errcheck" "maligned" "unconvert" "dupl" "structcheck" "varcheck" "safesql" "deadcode" "lll" "goimports" "gotype" "gosimple" "megacheck" "staticcheck" "unused" "interfacer" "unparam" "gochecknoinits" "gochecknoglobals" ; do
if [ "$OS" = "windows" ]; then
binexe="${binexe}.exe"
fi
Expand Down

0 comments on commit 3917f98

Please sign in to comment.