feat(v2): use nested eip-712 approach for isValidSignature #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
force-pushed
the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
from
046b0bc to
0c98b9d
Compare
jaypaik
changed the title
jaypaik
force-pushed
the
03-10-feat_use_solady_s_minimal_ERC-1967_proxy_and_UUPSUpgradeable
branch
from
1d1c48d to
fa694c6
Compare
jaypaik
force-pushed
the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
from
0c98b9d to
4e8b9ae
Compare
3 tasks
jaypaik
force-pushed
the
03-10-feat_use_solady_s_minimal_ERC-1967_proxy_and_UUPSUpgradeable
branch
from
fa694c6 to
9836dde
Compare
jaypaik
force-pushed
the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
from
4e8b9ae to
335cf09
Compare
jaypaik
force-pushed
the
03-10-feat_use_solady_s_minimal_ERC-1967_proxy_and_UUPSUpgradeable
branch
from
9836dde to
775df0e
Compare
jaypaik
force-pushed
the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
from
335cf09 to
51523a2
Compare
jaypaik
force-pushed
the
03-10-feat_use_solady_s_minimal_ERC-1967_proxy_and_UUPSUpgradeable
branch
from
775df0e to
4774a7f
Compare
jaypaik
force-pushed
the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
from
51523a2 to
d5dda60
Compare
adam-alchemy
approved these changes
Mar 14, 2024
| result := iszero(and(eq(chainid(), cachedChainId), eq(address(), cachedThis))) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
newline for consistency
There was a problem hiding this comment.
The source files don't have it and these are ported untouched - I'll keep it this way but happy to revisit later!
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.4; | ||
|
|
||
| /// @notice Contract for EIP-712 typed structured data hashing and signing. |
There was a problem hiding this comment.
Request to add the solady commit hash this was pulled from.
There was a problem hiding this comment.
Will probably track this in the readme or something upstack.
jaypaik
force-pushed
the
03-10-feat_use_solady_s_minimal_ERC-1967_proxy_and_UUPSUpgradeable
branch
from
ab666c3 to
b4f2a46
Compare
Base automatically changed from
03-10-feat_use_solady_s_minimal_ERC-1967_proxy_and_UUPSUpgradeable
to
develop
March 14, 2024 19:15
jaypaik
force-pushed
the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
from
d5dda60 to
04525d9
Compare
jaypaik
deleted the
03-12-feat_use_nested_eip-712_approach_for_isValidSignature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For transparent signing of messages (for the 712 case).
Inspired by:
Note that this removes the need for a typehash to be declared on the contract.