Skip to content

Commit

Permalink
fix: remove redundant _validateSignature
Browse files Browse the repository at this point in the history
  • Loading branch information
jaypaik committed Mar 12, 2024
1 parent 0342136 commit 727c647
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
7 changes: 0 additions & 7 deletions src/common/BaseLightAccount.sol
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,6 @@ abstract contract BaseLightAccount is BaseAccount, TokenCallbackHandler, UUPSUpg
/// @dev Must override to support ERC-1271 signature validation.
function isValidSignature(bytes32 hash, bytes memory signature) public view virtual override returns (bytes4);

/// @dev Must override to support user op validation.
function _validateSignature(PackedUserOperation calldata userOp, bytes32 userOpHash)
internal
virtual
override
returns (uint256);

/// @dev Must override to allow calls to protected functions.
function _isFromOwner() internal view virtual returns (bool);

Expand Down
2 changes: 1 addition & 1 deletion test/LightAccount.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ contract LightAccountTest is Test {
bytes32(uint256(uint160(0x0000000071727De22E5E9d8BAf0edAc6f37da032)))
)
),
0x366526c31a9f3ae63f66515d13f8e6888fe6edac9bc95296cb53e68006ad9888
0x615ee1c0ec29b577ecc3af52e02e448cdb583a906dd0debd02c5ca9048ef98a6
);
}

Expand Down
2 changes: 1 addition & 1 deletion test/MultiOwnerLightAccount.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ contract MultiOwnerLightAccountTest is Test {
bytes32(uint256(uint160(0x0000000071727De22E5E9d8BAf0edAc6f37da032)))
)
),
0x00e57e998a9d001dbf34b3abab4e0cdb4c57020ee08eaa3b639f167fbb87aa4c
0xcb9592a573d51d2b1e5d7fb8e2f8cbe547a5f1a680e5566c1d619fcb767f1fb7
);
}

Expand Down

0 comments on commit 727c647

Please sign in to comment.