-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: combine core and client stores #775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphilipson
requested review from
moldy530,
rthomare,
dancoombs and
mokok123
as code owners
June 24, 2024 23:21
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moldy530
previously approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple nits, but LGTM otherwise! Thanks for doing this
moldy530
force-pushed
the
dp/merge-stores
branch
from
July 16, 2024 22:15
aab1656
to
968496f
Compare
moldy530
approved these changes
Jul 16, 2024
moldy530
added a commit
that referenced
this pull request
Jul 17, 2024
* refactor: combine core and client stores * refactor: require stored state to contain alchemy and wagmi types --------- Co-authored-by: moldy <[email protected]>
moldy530
added a commit
that referenced
this pull request
Jul 30, 2024
* refactor: combine core and client stores * refactor: require stored state to contain alchemy and wagmi types --------- Co-authored-by: moldy <[email protected]>
moldy530
added a commit
that referenced
this pull request
Aug 13, 2024
* refactor: combine core and client stores * refactor: require stored state to contain alchemy and wagmi types --------- Co-authored-by: moldy <[email protected]>
moldy530
added a commit
that referenced
this pull request
Aug 28, 2024
* refactor: combine core and client stores * refactor: require stored state to contain alchemy and wagmi types --------- Co-authored-by: moldy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates the references to the
clientStore
tostore
in the Alchemy Accounts module.Detailed summary
config.clientStore
withconfig.store
in multiple functions