Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine core and client stores #775

Merged
merged 2 commits into from
Jul 17, 2024
Merged

refactor: combine core and client stores #775

merged 2 commits into from
Jul 17, 2024

Conversation

dphilipson
Copy link
Contributor

@dphilipson dphilipson commented Jun 24, 2024

PR-Codex overview

This PR updates the references to the clientStore to store in the Alchemy Accounts module.

Detailed summary

  • Replaced config.clientStore with config.store in multiple functions
  • Updated function calls and state accesses accordingly

The following files were skipped due to too many changes: account-kit/core/src/hydrate.ts, account-kit/core/src/store/types.ts, account-kit/core/src/store/client.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ❌ Failed (Inspect) Jul 16, 2024 10:28pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 10:28pm

moldy530
moldy530 previously approved these changes Jun 25, 2024
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits, but LGTM otherwise! Thanks for doing this

account-kit/core/src/store/types.ts Outdated Show resolved Hide resolved
account-kit/core/src/store/types.ts Outdated Show resolved Hide resolved
@moldy530 moldy530 dismissed their stale review June 28, 2024 20:52

The merge-base changed after approval.

@moldy530 moldy530 merged commit 12f9faf into v4.x.x Jul 17, 2024
5 of 6 checks passed
@moldy530 moldy530 deleted the dp/merge-stores branch July 17, 2024 15:05
moldy530 added a commit that referenced this pull request Jul 17, 2024
* refactor: combine core and client stores

* refactor: require stored state to contain alchemy and wagmi types

---------

Co-authored-by: moldy <[email protected]>
moldy530 added a commit that referenced this pull request Jul 30, 2024
* refactor: combine core and client stores

* refactor: require stored state to contain alchemy and wagmi types

---------

Co-authored-by: moldy <[email protected]>
moldy530 added a commit that referenced this pull request Aug 13, 2024
* refactor: combine core and client stores

* refactor: require stored state to contain alchemy and wagmi types

---------

Co-authored-by: moldy <[email protected]>
moldy530 added a commit that referenced this pull request Aug 28, 2024
* refactor: combine core and client stores

* refactor: require stored state to contain alchemy and wagmi types

---------

Co-authored-by: moldy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge core store and client store objects into one object within account-kit/core
2 participants