Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rn): make OTP the auth example #1307

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Jan 28, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the documentation and code for React Native integration with the Signer package, including updates to setup guides, sidebar navigation, and component implementations.

Detailed summary

  • Added "Next steps" section in getting-started-expo.mdx.
  • Updated TileButton title in overview.mdx to "Expo (recommended)".
  • Adjusted sidebar items in react-native.ts to include "Email Magic Link".
  • Replaced <button> elements with <Button> components in multiple .mdx files.
  • Enhanced prerequisites in prerequisites.mdx with details on Hermes and Fabric.
  • Expanded setup guide in setup-guide.mdx with additional information on email authentication methods and deep linking.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:38am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:38am

Copy link
Collaborator Author

moldy530 commented Jan 28, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@moldy530 moldy530 force-pushed the moldy/otp-primary-rn branch from c2a18f8 to 0a92869 Compare January 29, 2025 00:24
Copy link
Collaborator

@rthomare rthomare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Nice work!

@moldy530 moldy530 merged commit 0a92869 into moldy/rn-docs-base Jan 29, 2025
5 of 8 checks passed
@moldy530 moldy530 deleted the moldy/otp-primary-rn branch January 29, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants