docs(rn): add callouts for expo tsconfig and deployment targets #1304
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
howydev,
Zer0dot,
jaypaik,
Blu-J,
noam-alchemy,
jakehobbs and
archit2407
as code owners
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
| After running the above command for iOS, you need to update the `ios/Podfile.properties.json` to target iOS minimum version of 17.0 | ||
| ```json | ||
| { | ||
| // ...other settings | ||
| "ios.deploymentTarget": "17.0" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
So with the Expo prebuild flow, we don't want to be touching the generated native files (i.e files in the ios / android folders) cause they would get re-generated anytime the user does a Prebuild and our changes would be lost.
In this case we should tell the user to use expo-build-properties to configure the deploymentTarget.
This updates the native properties on either platform using a Config Plugin which means anytime a Prebuild happens, Expo knows to read update the build config to whatever we set here.
The docs are here https://docs.expo.dev/versions/latest/sdk/build-properties/
There was a problem hiding this comment.
oh lemme try that
moldy530
force-pushed
the
moldy/deployment-targets
branch
2 times, most recently
from
7e65197 to
b1bb334
Compare
moldy530
force-pushed
the
moldy/rn-docs-base
branch
from
a129185 to
97837b7
Compare
moldy530
force-pushed
the
moldy/deployment-targets
branch
2 times, most recently
from
85c8544 to
5fc3a4e
Compare
moldy530
force-pushed
the
moldy/deployment-targets
branch
from
5fc3a4e to
8dd7a73
Compare
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily updates the documentation for the
React Native Signerpackage, emphasizing the prerequisites, setup instructions, and compatibility with React Native's new architecture. It introduces a newprerequisites.mdxfile and integrates its content into various existing documentation files.Detailed summary
## Pre-requisitesinprerequisites.mdxlisting requirements for theReact Native Signer.Alchemy Signerbeing in Alpha from multiple files.Snippetcomponent to include prerequisite information inoverview.mdx,setup-guide.mdx,getting-started-rn-bare.mdx, andgetting-started-expo.mdx.getting startedsections across various files.