-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up / refactor demo app #1301
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
examples/ui-demo/src/components/configuration/ConfigurationWrapper.tsx
Outdated
Show resolved
Hide resolved
unrelated to your changes, but do you mind removing the import of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some small nits but otherwise looks great, thanks for doing this! lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The only possible regression I can find is that the "code preview" still shows now if you toggle it on & then shrink your viewport to mobile width. I don't have a problem with that though if others are okay with it.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the UI components in the
examples/ui-demo
directory, improving responsiveness, and refactoring imports for better organization. It introduces new components and updates existing ones to ensure a more cohesive user experience.Detailed summary
UserAvatar.tsx
to change adiv
class fromflex
tohidden lg:flex
.ConfigurationSidebarWrapper
component inConfigurationSidebarWrapper.tsx
.MobileSplashPage.tsx
for better responsiveness.Styling.tsx
for consistency.TopNav.tsx
.EOAPostLogin
styles for better layout.ValueProps.tsx
andUserConnectionAvatar.tsx
for proper paths.RenderUserConnectionAvatar
for improved structure.PreviewNav
andPreviewWrapper
components for better navigation and layout.AuthCardWrapper
and streamlined the main layout inpage.tsx
.