Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up / refactor demo app #1301

Merged
merged 8 commits into from
Jan 29, 2025
Merged

fix: clean up / refactor demo app #1301

merged 8 commits into from
Jan 29, 2025

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Jan 28, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the UI components in the examples/ui-demo directory, improving responsiveness, and refactoring imports for better organization. It introduces new components and updates existing ones to ensure a more cohesive user experience.

Detailed summary

  • Updated UserAvatar.tsx to change a div class from flex to hidden lg:flex.
  • Added ConfigurationSidebarWrapper component in ConfigurationSidebarWrapper.tsx.
  • Modified layout in MobileSplashPage.tsx for better responsiveness.
  • Refactored imports in Styling.tsx for consistency.
  • Changed z-index in TopNav.tsx.
  • Adjusted EOAPostLogin styles for better layout.
  • Updated icon imports in ValueProps.tsx and UserConnectionAvatar.tsx for proper paths.
  • Refactored RenderUserConnectionAvatar for improved structure.
  • Introduced PreviewNav and PreviewWrapper components for better navigation and layout.
  • Removed AuthCardWrapper and streamlined the main layout in page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 10:28pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 10:28pm

Copy link

graphite-app bot commented Jan 28, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@linnall
Copy link
Collaborator

linnall commented Jan 29, 2025

unrelated to your changes, but do you mind removing the import of RenderUserConnectionAvatar here since it is not being used 🙏

linnall
linnall previously approved these changes Jan 29, 2025
Copy link
Collaborator

@linnall linnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small nits but otherwise looks great, thanks for doing this! lgtm

Copy link
Member

@jakehobbs jakehobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only possible regression I can find is that the "code preview" still shows now if you toggle it on & then shrink your viewport to mobile width. I don't have a problem with that though if others are okay with it.

@RobChangCA RobChangCA merged commit 4c3956c into main Jan 29, 2025
7 checks passed
@RobChangCA RobChangCA deleted the rob/refactor-main branch January 29, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants