-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: session expiration improvements #1291
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
d743ebf
to
ae37680
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the session management and configuration for the
account-kit
library. It introduces a newsessionConfig
object, updates documentation, and modifies test cases to reflect changes in session length handling.Detailed summary
environment: "jsdom"
invitest.config.ts
.sessionLength
description in documentation to indicate deprecation.CreateStorageFn
type for storage configuration.CreateStorageFn
inCreateConfigProps
.createConfig
to verify session length and expiration time.SessionManager
tests to check expiration time configuration.sessionConfig
option to override default session manager config inquickstart.mdx
.sessionLength
incookieStorage
function and updated its documentation.MAX_COOKIE_DURATION_MS
constant for cookie duration limits.