Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: session expiration improvements #1291

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jakehobbs
Copy link
Member

@jakehobbs jakehobbs commented Jan 24, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the session management and configuration for the account-kit library. It introduces a new sessionConfig object, updates documentation, and modifies test cases to reflect changes in session length handling.

Detailed summary

  • Added environment: "jsdom" in vitest.config.ts.
  • Updated sessionLength description in documentation to indicate deprecation.
  • Introduced CreateStorageFn type for storage configuration.
  • Replaced inline storage configuration with CreateStorageFn in CreateConfigProps.
  • Added tests for createConfig to verify session length and expiration time.
  • Updated SessionManager tests to check expiration time configuration.
  • Added sessionConfig option to override default session manager config in quickstart.mdx.
  • Deprecated sessionLength in cookieStorage function and updated its documentation.
  • Introduced MAX_COOKIE_DURATION_MS constant for cookie duration limits.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 0:10am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 0:10am

Copy link

graphite-app bot commented Jan 24, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant