Minor style improvements

modules/core/inc/tactile/core/map/layer/layer_visitor.hpp

@@ -23,24 +23,21 @@ class ILayerVisitor {
    *
    * \param layer the visited layer.
    */
-  virtual void visit([[maybe_unused]] TileLayer& layer)
-  {}
+  virtual void visit([[maybe_unused]] TileLayer& layer) {}
 
   /**
    * \brief Visits an object layer.
    *
    * \param layer the visited layer.
    */
-  virtual void visit([[maybe_unused]] ObjectLayer& layer)
-  {}
+  virtual void visit([[maybe_unused]] ObjectLayer& layer) {}
 
   /**
    * \brief Visits a group layer.
    *
    * \param layer the visited layer.
    */
-  virtual void visit([[maybe_unused]] GroupLayer& layer)
-  {}
+  virtual void visit([[maybe_unused]] GroupLayer& layer) {}
 };
 
 /**

modules/core/test/testutil/meta_context_helpers.hpp

@@ -18,50 +18,23 @@ class MetaContextVisitorTester final : public IMetaContextVisitor {
   int tileset_count {0};
   int tile_count {0};
 
-  void visit([[maybe_unused]] OrthogonalMap& map) override
-  {
-    ++orthogonal_map_count;
-  }
+  void visit([[maybe_unused]] OrthogonalMap& map) override { ++orthogonal_map_count; }
 
-  void visit([[maybe_unused]] IsometricMap& map) override
-  {
-    ++isometric_map_count;
-  }
+  void visit([[maybe_unused]] IsometricMap& map) override { ++isometric_map_count; }
 
-  void visit([[maybe_unused]] HexagonalMap& map) override
-  {
-    ++hexagonal_map_count;
-  }
+  void visit([[maybe_unused]] HexagonalMap& map) override { ++hexagonal_map_count; }
 
-  void visit([[maybe_unused]] GroupLayer& layer) override
-  {
-    ++group_layer_count;
-  }
+  void visit([[maybe_unused]] GroupLayer& layer) override { ++group_layer_count; }
 
-  void visit([[maybe_unused]] TileLayer& layer) override
-  {
-    ++tile_layer_count;
-  }
+  void visit([[maybe_unused]] TileLayer& layer) override { ++tile_layer_count; }
 
-  void visit([[maybe_unused]] ObjectLayer& layer) override
-  {
-    ++object_layer_count;
-  }
+  void visit([[maybe_unused]] ObjectLayer& layer) override { ++object_layer_count; }
 
-  void visit([[maybe_unused]] Object& object) override
-  {
-    ++object_count;
-  }
+  void visit([[maybe_unused]] Object& object) override { ++object_count; }
 
-  void visit([[maybe_unused]] Tileset& tileset) override
-  {
-    ++tileset_count;
-  }
+  void visit([[maybe_unused]] Tileset& tileset) override { ++tileset_count; }
 
-  void visit([[maybe_unused]] Tile& tile) override
-  {
-    ++tile_count;
-  }
+  void visit([[maybe_unused]] Tile& tile) override { ++tile_count; }
 };
 
 }  // namespace tactile::testutil

modules/foundation/inc/tactile/foundation/container/string_map.hpp

@@ -7,8 +7,8 @@
 #include <unordered_map>  // unordered_map
 
 #include "tactile/foundation/api.hpp"
-#include "tactile/foundation/prelude.hpp"
 #include "tactile/foundation/container/string.hpp"
+#include "tactile/foundation/prelude.hpp"
 
 namespace tactile {
 

modules/foundation/inc/tactile/foundation/functional/hash.hpp

@@ -27,12 +27,11 @@ void hash_combine(usize& seed, const T& value) noexcept
 
 }  // namespace tactile
 
-#define TACTILE_IMPLEMENT_HASH(Type, ...)                           \
-  template <>                                                       \
-  struct std::hash<Type> final {                                    \
-    [[nodiscard]] auto operator()(const Type& value) const noexcept \
-        -> tactile::usize                                           \
-    {                                                               \
-      return tactile::hash_combine(__VA_ARGS__);                    \
-    }                                                               \
+#define TACTILE_IMPLEMENT_HASH(Type, ...)                                             \
+  template <>                                                                         \
+  struct std::hash<Type> final {                                                      \
+    [[nodiscard]] auto operator()(const Type& value) const noexcept -> tactile::usize \
+    {                                                                                 \
+      return tactile::hash_combine(__VA_ARGS__);                                      \
+    }                                                                                 \
   }

modules/foundation/src/tactile/foundation/debug/generic_error.cpp

@@ -27,7 +27,7 @@ class GenericErrorCategory final : public std::error_category {
       case GenericError::kIOError: return "unknown I/O error";
     }
 
-    return "unknown";
+    return "?";
   }
 };
 

modules/foundation/src/tactile/foundation/io/compression/compression_error.cpp

@@ -22,7 +22,7 @@ class CompressionErrorCategory final : public std::error_category {
       case CompressionError::kInvalidMode: return "detected an invalid compression mode";
     }
 
-    return "unknown";
+    return "?";
   }
 };
 

modules/foundation/src/tactile/foundation/io/ir.cpp

@@ -12,8 +12,8 @@ auto get_attribute_type(const Component& component, StringView attr_name)
   const auto attribute_iter =
       std::find_if(component.attributes.begin(),
                    component.attributes.end(),
-                   [attr_name](const ir::NamedAttribute& attribute) {
-                     return attribute.name == attr_name;
+                   [attr_name](const ir::NamedAttribute& stored_attribute) {
+                     return stored_attribute.name == attr_name;
                    });
 
   if (attribute_iter != component.attributes.end()) {

modules/foundation/src/tactile/foundation/platform/dynamic_library.cpp

@@ -48,10 +48,7 @@ class UnixDynamicLibrary final : public IDynamicLibrary {
     return dlsym(mHandle, name);
   }
 
-  [[nodiscard]] auto get_path() const -> const FilePath& override
-  {
-    return mPath;
-  }
+  [[nodiscard]] auto get_path() const -> const FilePath& override { return mPath; }
 
  private:
   FilePath mPath;
@@ -96,10 +93,7 @@ class Win32DynamicLibrary final : public IDynamicLibrary {
     return static_cast<void*>(GetProcAddress(mHandle, name));
   }
 
-  [[nodiscard]] auto get_path() const -> const FilePath& override
-  {
-    return mPath;
-  }
+  [[nodiscard]] auto get_path() const -> const FilePath& override { return mPath; }
 
  private:
   FilePath mPath;

modules/foundation/test/io/filesystem_test.cpp

@@ -24,7 +24,6 @@ TEST(Filesystem, GetPersistentStorageDirectory)
   EXPECT_NO_THROW((void) get_persistent_storage_directory());
 }
 
-
 /// \tests tactile::normalize_path
 TEST(Filesystem, NormalizePath)
 {
@@ -39,7 +38,8 @@ TEST(Filesystem, ShortenHomeDirectoryPrefix)
 
   EXPECT_EQ(shorten_home_directory_prefix(home), "~");
   EXPECT_EQ(shorten_home_directory_prefix(home.string() + "/foo/"), "~/foo/");
-  EXPECT_EQ(shorten_home_directory_prefix(home.string() + "/foo/bar.txt"), "~/foo/bar.txt");
+  EXPECT_EQ(shorten_home_directory_prefix(home.string() + "/foo/bar.txt"),
+            "~/foo/bar.txt");
   EXPECT_EQ(shorten_home_directory_prefix(home.string() + '/'), "~/");
 
   EXPECT_FALSE(shorten_home_directory_prefix("/a/b").has_value());

modules/foundation/test/io/save/save_format_context_test.cpp

@@ -1,10 +1,10 @@
 // Copyright (C) 2023 Albin Johansson (GNU General Public License v3.0)
 
+#include "tactile/foundation/io/save/save_format_context.hpp"
+
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
-#include "tactile/foundation/io/save/save_format_context.hpp"
-
 using namespace tactile;
 using testing::Return;
 

modules/opengl/src/tactile/opengl/opengl_error.cpp

@@ -19,18 +19,18 @@ class OpenGLErrorCategory final : public std::error_category {
   auto message(const int value) const -> std::string override
   {
     switch (OpenGLError {value}) {
-      case OpenGLError::kUnknown: return "unknown";
-      case OpenGLError::kInvalidEnum: return "invalid enum";
-      case OpenGLError::kInvalidValue: return "invalid value";
-      case OpenGLError::kInvalidOperation: return "invalid operation";
-      case OpenGLError::kStackOverflow: return "stack overflow";
-      case OpenGLError::kStackUnderflow: return "stack underflow";
-      case OpenGLError::kOutOfMemory: return "out of memory";
-      case OpenGLError::kInvalidFramebufferOperation:
-        return "invalid framebuffer operation";
+      using enum OpenGLError;
+      case kUnknown: return "unknown";
+      case kInvalidEnum: return "invalid enum";
+      case kInvalidValue: return "invalid value";
+      case kInvalidOperation: return "invalid operation";
+      case kStackOverflow: return "stack overflow";
+      case kStackUnderflow: return "stack underflow";
+      case kOutOfMemory: return "out of memory";
+      case kInvalidFramebufferOperation: return "invalid framebuffer operation";
     }
 
-    return "unknown";
+    return "?";
   }
 };
 

modules/tactile-yml-format/inc/tactile/tactile-yml-format/emit/meta_emitter.hpp

@@ -17,4 +17,4 @@ TACTILE_YML_FORMAT_API void emit(YAML::Emitter& emitter, const Attribute& value)
 TACTILE_YML_FORMAT_API void emit_metadata(YAML::Emitter& emitter,
                                           const ir::Metadata& metadata);
 
-}  // namespace tactile
+}  // namespace tactile::yml_format

modules/tmj-format/inc/tactile/tmj-format/load/tmj_meta_parser.hpp

@@ -16,4 +16,4 @@ TACTILE_TMJ_API auto parse_property(const JSON& json) -> Result<ir::NamedAttribu
 [[nodiscard]]
 TACTILE_TMJ_API auto parse_metadata(const JSON& json, ir::Metadata& meta) -> Result<void>;
 
-}  // namespace tactile
+}  // namespace tactile::tmj

modules/tmj-format/src/tactile/tmj-format/load/tmj_tileset_parser.cpp

@@ -7,8 +7,8 @@
 
 #include <fmt/std.h>
 
-#include "tactile/foundation/log/logger.hpp"
 #include "tactile/foundation/io/save/save_format_error.hpp"
+#include "tactile/foundation/log/logger.hpp"
 #include "tactile/tmj-format/common/json.hpp"
 #include "tactile/tmj-format/load/tmj_layer_parser.hpp"
 #include "tactile/tmj-format/load/tmj_meta_parser.hpp"

modules/tmj-format/test/emit/tmj_object_emitter_test.cpp

@@ -76,4 +76,3 @@ TEST_P(ParameterizedTmjObjectEmitterTest, EmitObject)
   EXPECT_EQ(object_json.at("properties").at(1).at("type"), "string");
   EXPECT_EQ(object_json.at("properties").at(1).at("value"), "XYZ");
 }
-