Fixes session scope handling for CORS Policy Service (#12)

albertodall · Sep 29, 2020 · 18c8a12 · 18c8a12
1 parent f4dac9e
commit 18c8a12
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/IdentityServer4.NHibernate.Storage/Services/CorsPolicyService.cs b/IdentityServer4.NHibernate.Storage/Services/CorsPolicyService.cs
@@ -39,7 +39,8 @@ public async Task<bool> IsOriginAllowedAsync(string origin)
         {
             bool isAllowed;
 
-            using (var session = _context.HttpContext.RequestServices.GetRequiredService<IStatelessSession>())
+            var session = _context.HttpContext.RequestServices.GetRequiredService<IStatelessSession>();
+            using (var tx = session.BeginTransaction())
             {
                 ClientCorsOrigin corsOriginAlias = null;
                 var corsOriginsQuery = session.QueryOver<Client>()
@@ -51,6 +52,7 @@ public async Task<bool> IsOriginAllowedAsync(string origin)
                     ));
 
                 var origins = await corsOriginsQuery.ListAsync<string>();
+                await tx.CommitAsync();
 
                 isAllowed = origins.Any();
             }

diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -1,5 +1,14 @@
+## Build 2.1.2
+_Release notes - IdentityServer4.NHibernate - Version 2.1.2_
+
+__New features__
+- None
+
+__Resolved Issues__
+- [#11](https://github.com/albertodall/IdentityServer4.NHibernate/issues/11) - Session is closed exception ([@lcetinapta](https://github.com/lcetinapta)) 
+
 ## Build 2.1.1
-_Release notes - IdentityServer4.NHibernate - Version 2.1.0_
+_Release notes - IdentityServer4.NHibernate - Version 2.1.1_
 
 __New features__
 - None