Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use tilde for typescript versions in templates #217

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Nov 8, 2024

The typescript package doesn't follow semver, see microsoft/TypeScript#14116

Every minor version bump can lead to breaking changes, see https://github.com/microsoft/TypeScript/wiki/Breaking-Changes

Use tilde instead of caret to ensure that npm doesn't install beyond the specified minor version.

The typescript package doesn't follow semver, see microsoft/TypeScript#14116

Every minor version bump can lead to breaking changes, see https://github.com/microsoft/TypeScript/wiki/Breaking-Changes

Use tilde instead of caret to ensure that npm doesn't install beyond the
specified minor version.
Copy link
Owner

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, make sense. Thanks for the PR!

Could you fix the merge conflicts, then I can merge this.

@xuhdev
Copy link
Contributor Author

xuhdev commented Nov 13, 2024

@aklinker1 Could you merge this? It looks like there's another PR remaining in the "approved" status without being merged 😄

@aklinker1
Copy link
Owner

I have to approve and run checks, so sometimes it takes a few hours or days for me to get back to the PR after they've passed.

@aklinker1 aklinker1 changed the title Use tilde for typescript versions chore: Use tilde for typescript versions in templates Nov 13, 2024
@aklinker1 aklinker1 merged commit 5a13880 into aklinker1:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants