Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing with AWS Keyspaces #866

Closed
wants to merge 10 commits into from
Closed

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Feb 17, 2021

Just to show what changes I had to do to run tests with Amazon Keyspaces

See test results in #865 (comment)

@@ -140,7 +140,7 @@ akka.persistence.cassandra {

# Maximum number of messages that will be batched when using `persistAsync`.
# Also used as the max batch size for deletes.
max-message-batch-size = 100
max-message-batch-size = 30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batches with more than 30 statements are not supported

# the journal does not use any counters or collections
default-idempotence = true
}
}
akka-persistence-cassandra-snapshot-profile {
basic.request {
consistency = ONE
consistency = LOCAL_QUORUM
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to use LOCAL_ONE for the reads but fails so might be required for the writes.

@ignasi35
Copy link
Contributor

ignasi35 commented Apr 22, 2021

Added a bunch of changes:

  • Given a pre-existing keyspace (manually created) the tests use (1) table auto creation, (2) an active-wait (using the metadata API) until all tables are created.
  • Similarly, at the end of a tests, tables are dropped one by one and the same active-wait (using the metadata API) kicks in until all tables are dropped.

I opted for reusing the keyspace because "create tables" is faster than "create a keyspace, and then the tables" so I shaved 20 seconds from each test run.

Tried to keep the ratio: "1 commit :: 1 test fixed"

@patriknw patriknw closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants