Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to connect with certs and key #5

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

b123400
Copy link
Contributor

@b123400 b123400 commented Dec 30, 2023

It now reads ca_file key_file and cert_file from config.
I've successfully connected to the staging environment and ping.

@akiroz
Copy link
Owner

akiroz commented Jan 2, 2024

@b123400 does rustls check the server's cert using your system's well known CAs if you don't provide a CA? or does it just not check the server at all?

@b123400
Copy link
Contributor Author

b123400 commented Jan 2, 2024

I don't think it read from the system, there's crate for that tho
https://github.com/rustls/rustls-native-certs

If I don't provide a CA it would fail, something like this

Err(Tls(Io(Custom { kind: InvalidData, error: InvalidCertificate(UnknownIssuer) })))

@akiroz akiroz merged commit ef47dcd into akiroz:rust-rewrite Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants