Additional Optimizations and OpenMP Support #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional overloaded methods for LogReg precision and recall methods given a vector of predicted outputs.
Added additional method declarations for overloaded precision and recall methods.
Added additional overloaded methods for LogReg's precision and recall methods to accept a vector of already-predicted outputs. Also fixed a mistake from the previous commit where an if-statement was not removed from LogReg's accuracy method to eliminate branching.
Went through all ml files and reduced for-loops containing an iterative if-statement to addition of a boolean expression to eliminate branching.
Adding OpenMP as a non-required link target in the CMake file for future multi-threaded expansion in library modules.
Added OpenMP multithreading support to applicable loops where processes could be parallelized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional overloaded methods were created for LogReg's precision and recall methods using a vector of already-predicted data.
Additional for-loops containing an iterative if-statement were reduced to contain a boolean expression to eliminate branching.
Root CMakeLists.txt file was modified to also search for OpenMP library for inclusion for future implementation of multi-threading in applicable modules.
Note: Testing of CMake installation is required to ensure that OpenMP inclusion is implemented correctly.