Fix Formatter
trait toJson
and toVue
methods
#8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really like this library so far, thanks for your work on it!
This PR introduces a fix to both the
toVue
andtoJson
methods inside theFormatter
trait. ThetoVue
method would throw an exception due tojson_decode
being called on thegetSeries()
result which returns an array, rather than on thegetOptions()
result which is a JSON encoded string.I've also tweaked the config doc to more clearly indicate its purpose and added a link to the docs for user help. In addition, I've also removed some unnecessary
@test
annotations in the existing PHPUnit tests, as the method names are already prefixed withtest
.If we're able to get this merged I'd be happy to make some more PR's adding more documentation and such.
Let me know if you'd like anything changed or adjusted. Thanks for your time! 🙏