Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Formatter trait toJson and toVue methods #8

Merged
merged 7 commits into from
Apr 1, 2024

Conversation

stevebauman
Copy link
Contributor

Really like this library so far, thanks for your work on it!

This PR introduces a fix to both the toVue and toJson methods inside the Formatter trait. The toVue method would throw an exception due to json_decode being called on the getSeries() result which returns an array, rather than on the getOptions() result which is a JSON encoded string.

I've also tweaked the config doc to more clearly indicate its purpose and added a link to the docs for user help. In addition, I've also removed some unnecessary @test annotations in the existing PHPUnit tests, as the method names are already prefixed with test.

If we're able to get this merged I'd be happy to make some more PR's adding more documentation and such.

Let me know if you'd like anything changed or adjusted. Thanks for your time! 🙏

@denisdulici denisdulici merged commit 5911841 into akaunting:master Apr 1, 2024
11 checks passed
@denisdulici
Copy link
Member

Thanks Steve for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants