Treat empty tables the same as non-empty tables #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jomonson, that's a great find! I'll get back to this! |
|
@jomonson I added unit tests and improved the regex to deal with varying numbers of spaces. Maybe this isn't an issue with what PostgreSQL produces, but won't this be a bit more future proof just in case? |
akaihola
force-pushed
the
patch-1
branch
3 times, most recently
from
bf7dec7 to
f8f1af3
Compare
Currently there is a bug when there are empty tables added to the schema. The dump file then contains an empty COPY statement that is currently mishandled and causes the script to skip to count 9999
akaihola
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug when there are empty tables added to the schema. The dump file then contains an empty COPY statement that is currently mishandled and causes the script to skip to count 9999