Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of files with exotic newlines #790

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix handling of files with exotic newlines #790

merged 3 commits into from
Jan 7, 2025

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Dec 30, 2024 •
edited
Loading

Fixes #768

@akaihola akaihola added the bug Something isn't working label Dec 30, 2024
@akaihola akaihola self-assigned this Dec 30, 2024
@akaihola akaihola force-pushed the nonascii-verification-fail branch from 9aae889 to b01cdb5 Compare December 30, 2024 20:19
@akaihola akaihola marked this pull request as draft December 30, 2024 20:22
@akaihola akaihola force-pushed the nonascii-verification-fail branch 2 times, most recently from 2622799 to ff5159a Compare January 3, 2025 15:54
@akaihola akaihola requested a review from Carreau January 3, 2025 15:55
@akaihola akaihola force-pushed the nonascii-verification-fail branch from ff5159a to b78c09e Compare January 3, 2025 16:56
@akaihola akaihola force-pushed the nonascii-verification-fail branch 2 times, most recently from 22df062 to a85444d Compare January 7, 2025 20:47
@akaihola akaihola force-pushed the nonascii-verification-fail branch from a85444d to 3f71f11 Compare January 7, 2025 20:49
@akaihola akaihola marked this pull request as ready for review January 7, 2025 20:58
@akaihola akaihola merged commit 1a77306 into master Jan 7, 2025
34 of 35 checks passed
@akaihola akaihola deleted the nonascii-verification-fail branch January 7, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

Assignees

@akaihola akaihola

Labels
bug Something isn't working
Projects
Darker and Graylint development
Status: Done
Milestone
Darker 3.1.1 - Bugfix release
Development

Successfully merging this pull request may close these issues.

darker.verification.NotEquivalentError: nonascii2.py (IPython test file)
2 participants
@akaihola @Carreau