Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename node.type -> node.name #364

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Rename node.type -> node.name #364

merged 2 commits into from
Jan 8, 2025

Conversation

ajthinking
Copy link
Owner

@ajthinking ajthinking commented Jan 8, 2025

This PR moves Node.type to Node.name
This makes sense since NodeDescription and Computer both use name as entity identifier.

⚠️ will likely break serialized diagrams

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 9:57am

@ajthinking ajthinking merged commit 861c1e2 into main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant