add month suffix M to asv --date-period argument
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoZeke
requested changes
Nov 10, 2023
HaoZeke
requested changes
Nov 10, 2023
Comment on lines
+110
to
+111
| ("M", int(60 * 60 * 24 * 7 * 52 / 12)), | ||
| ("q", int(60 * 60 * 24 * 7 * 52 / 4)), |
There was a problem hiding this comment.
Just as a stylistic nit, are the conversions for the other suffixes done elsewhere? It would be nice to be consistent perhaps.
There was a problem hiding this comment.
I don't think so, the place it's being used in the asv flow is here:
https://github.com/airspeed-velocity/asv/blob/b8cbf81ccb808158102692a6fc42b8a9b2f2861e/asv/util.py#L187
and there's not type guard there. Should there be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
asv --date-period, there is no option for months or quarters; this might be useful for running benchmarks for projects with a quarterly or monthly release scheduleAlso, where would I add documentation for these suffixes? I couldn't find it on the RTD page, and accidentally used
mfor month, not knowing it was minutes, and was confused when there were way more commits than I expected