fix: lower maximum fee placeholder because of Paris max gas limit change #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
force-pushed
the
fix/gas_limit_too_high
branch
from
cb88e62 to
6302854
Compare
|
Done, I also tested locally and I can get the fee estimation correctly. @AndreasGassmann can you review the changes ? |
|
@khanti42 Thanks, merged! |
|
@mattgale33 In order for this fix to go live it needs both this repo and the snaps repo here to have the fixed merged. The snaps update after the pull request has been merged and the npm repository updated with the latest version it can still take 1-2 days, as we need to review the changes of the snaps and allow list the new version. We will comment in and close the associated issue when the fix is live so that you can test it and confirm if it solves your issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Enregistrement.de.l.ecran.2024-08-19.a.15.22.48.mov
Still failing because maximum gas limit has to been changed in the snap as well: https://github.com/airgap-it/tezos-metamask-snap