Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live-tests): add enable proxy flag to live tests #52646

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

lazebnyi
Copy link
Collaborator

What

Some connectors have certificates embedded in their libraries without providing an option to disable this feature. What could follow to issues with regression testing.

Fixed https://github.com/airbytehq/airbyte-internal-issues/issues/11467

How

Add --disable-proxy flag

@lazebnyi lazebnyi requested a review from a team January 30, 2025 02:29
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 0:54am

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a version bump for live-tests package in pyproject.toml, and do poetry lock on it — it might pick up new deps updates.

Overall looks solid, but I have not looked into the regression tests failure that I assume you triggered manually.

@lazebnyi lazebnyi requested a review from maxi297 January 30, 2025 03:20
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 30, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (8febdeb)

@lazebnyi lazebnyi merged commit ad3550c into master Jan 30, 2025
28 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/add-enable-proxy-flag-to-live-tests branch January 30, 2025 13:21
stephane-airbyte pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants