Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨Source Zoho CRM: Migrate to poetry #42864

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

🚨Source Zoho CRM: Migrate to poetry #42864

wants to merge 6 commits into from

Conversation

pabloescoder
Copy link
Collaborator

What

Migrating the connector to Poetry

Can this PR be safely reverted and rolled back?

  • YES 💚

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:05am

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 29, 2024
natikgadzhi
natikgadzhi reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloescoder let's dust this off — if you resolve the conflicts and bump this to new base image, I'll be happy to re-run tests and send this over to progressive rollout.

airbyte-integrations/connectors/source-zoho-crm/metadata.yaml Outdated
@@ -2,44 +2,46 @@ data:
ab_internal:
ql: 200
sl: 100
connectorBuildOptions:
baseImage: docker.io/airbyte/python-connector-base:2.0.0@sha256:c44839ba84406116e8ba68722a0f30e8f6e7056c726f447681bb9e9ece8bd916
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloescoder can you bump this to 3.0 while we're here? I want to send this over to progressive rollout and see if we can ship this.

@pabloescoder
Copy link
Collaborator Author

pabloescoder commented Jan 28, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (a166b98)

@natikgadzhi
Copy link
Contributor

Just one failing acceptance test with incremental syncs with large state. It could be that this is OK as the cdk version is old. I’m okay shipping as is in progressive rollout @DanyloGL

@pabloescoder
Copy link
Collaborator Author

@natikgadzhi Did we do a progressive rollout for this?

@DanyloGL
Copy link
Collaborator

DanyloGL commented Feb 3, 2025

Incremental sync test fails. Trying to find good cloud connection for regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zoho-crm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pabloescoder @natikgadzhi @DanyloGL @octavia-squidington-iii