Fix return hint for EnumerableSpace.get_elements() and simplify implementations #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhuet
force-pushed
the
simplify-get-elements
branch
from
eb191a0 to
d3fff1a
Compare
…mentations In code, the result of `EnumerableSpace.get_elements()` is used for: - `for a in elements` - `if a in elements` - `elements[i]` - `len(elements)` - `random.sample(elements, 2)` So this is actually expected to be `Sequence`. We fix the annotation and simplify the implementation by removing the wrapping in numpy.array() as it is not expected and even sometimes re-wrap in a numpy.array() in the code.
nhuet
force-pushed
the
simplify-get-elements
branch
from
d3fff1a to
27d3883
Compare
fteicht
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code, the result of
EnumerableSpace.get_elements()is used for:for a in elementsif a in elementselements[i]len(elements)random.sample(elements, 2)So this is actually expected to be a
Sequence(see https://docs.python.org/3/library/collections.abc.html#collections-abstract-base-classes).We fix the annotation and simplify the implementations by removing the wrapping in
numpy.array()as it is not required and even sometimes re-wrapped in anumpy.array()elsewhere in the code.