Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example of mid-variable acronym naming #2864

Closed
wants to merge 1 commit into from
Closed

Provide example of mid-variable acronym naming #2864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3521,7 +3521,7 @@ Other Style Guides
];

// also good
const httpRequests = [
const httpUrlRequests = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first, let's keep httpRequests; but second, Url is literally never correct, ever, and should never appear in your code, so this would be a very bad example to provide.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Url is correct in this case in Google's TypeScript, JavaScript, and C++ style guides

https://google.github.io/styleguide/tsguide.html#camel-case
https://google.github.io/styleguide/jsguide.html#naming-camel-case-defined
https://google.github.io/styleguide/cppguide.html#General_Naming_Rules

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately Google's style guides haven't ever been considered idiomatic by the wider ecosystem.

// ...
];

Expand Down
Loading