Stripe plugin for Api #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kappa-london
commented
Jul 13, 2021
kappa-london
commented
- Not the final version! for test and review
- Return value for Header() and Print"" needs a review ( we could not use your approach here )
- Return from bank functions needs some review and routes
- Not the final version! for test and review - Return value for Header() and Print"" needs a review. - Return from bank functions needs some review and routes
aimeos
reviewed
Jul 27, 2021
Comment on lines
+50
to
+59
| header('Access-Control-Allow-Origin: http://127.0.0.1:3000'); | ||
| header('Access-Control-Allow-Credentials: true'); | ||
| print json_encode(['data'=>['clientSecret'=>$intent->client_secret],'info'=>[ | ||
| 'amount' => $total, | ||
| 'currency' => $currency, | ||
| 'metadata' => ['integration_check' => 'accept_a_payment'], | ||
| 'verify'=>$this->getConfigValue( 'payment.url-update' ) | ||
| ]]); | ||
| exit; | ||
| // return new \Aimeos\MShop\Common\Helper\Config\Standard( '', 'POST', [] ); |
There was a problem hiding this comment.
You definitely need to use the Form helper to return the data to the client in a jsonapi.org compatible format. This means that you need to change your PWA client that it doesn't expect this format but JSON API standard format instead. Your custom data will then be available in the "meta" section.
There was a problem hiding this comment.
We will come back with another implementation. Many thanks for answering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.