Support aiida 2.5 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw a failing mock_code test since aiida 2.3.0 This was caused by just a whitespace change in the AiiDA submission script (controlled by the direct Scheduler plugin). Concretely, there was an extra space at the end of the last line of the script (the executable line) before 2.3. As a short term solution to preserve the existing hashes, we append a space if the script doesn't end with one. This change is purely for backwards compatibility and should be reverted right after 0.0.1 release.
ltalirz
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw a failing mock_code test since aiida 2.3.0 (see #75)
This was caused by just a whitespace change in the AiiDA
submission script (controlled by the direct Scheduler plugin).
Concretely, there was an extra space at the end of the last
line of the script (the executable line) before 2.3.
As a short term solution to preserve the existing hashes,
we append a space if the script doesn't end with one.
This change is purely for backwards compatibility and should be
reverted right after 0.0.1 release.
As a longer term solution we should make this less brittle, perhaps by removing all white space in the submission script. But even that still makes us dependent on the core.direct scheduler implementation. I'll open a separate issue to track that.
Closes #75