Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops: Add explicit sphinx.configuration key to RTD conf #6700

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 10, 2025

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (d17c293) to head (81d6f07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6700   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         563      563           
  Lines       41761    41761           
=======================================
  Hits        32567    32567           
  Misses       9194     9194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sphuber sphuber requested a review from mbercx January 10, 2025 21:26
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! @sphuber

@unkcpz unkcpz merged commit 8440416 into aiidateam:main Jan 10, 2025
10 checks passed
@unkcpz
Copy link
Member

unkcpz commented Jan 10, 2025

Sorry, I just find it conflict with PR from @danielhollas #6685
Seems in his PR the section by running sphnix command with uv run therefore this one is not needed anymore?

@danielhollas
Copy link
Collaborator

Yeah, unfortunately in order to use the lockfile, we can't use the sphinx section, and need to write out the uv run command manually.

@danielhollas
Copy link
Collaborator

Anyway, good find @sphuber.

I ran into this in aiidalab-widgets-base repo and was thoroughly confused. Looks like we'll have to fix this in a bunch more places in aiidalab repos.

@sphuber
Copy link
Contributor Author

sphuber commented Jan 11, 2025

Not sure about using uv, but according to the RTD docs, as of January 13 2025 having the explicit sphinx.configuration key is required, or they shut down the builds. Not sure if that is still compatible with using uv regardless

@sphuber
Copy link
Contributor Author

sphuber commented Jan 11, 2025

And yes, I got the notice for aiida-core and aiida-shell but all projects on RTD will be affected and need to be updated.

@sphuber sphuber deleted the fix/rtd-configuration branch January 11, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants