-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devops: Add explicit sphinx.configuration
key to RTD conf
#6700
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6700 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 563 563
Lines 41761 41761
=======================================
Hits 32567 32567
Misses 9194 9194 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! @sphuber
Sorry, I just find it conflict with PR from @danielhollas #6685 |
Yeah, unfortunately in order to use the lockfile, we can't use the sphinx section, and need to write out the uv run command manually. |
Anyway, good find @sphuber. I ran into this in aiidalab-widgets-base repo and was thoroughly confused. Looks like we'll have to fix this in a bunch more places in aiidalab repos. |
Not sure about using |
And yes, I got the notice for |
See https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/