-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repository issue templates #4148
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4148 +/- ##
===========================================
+ Coverage 78.89% 78.89% +0.01%
===========================================
Files 467 467
Lines 34481 34481
===========================================
+ Hits 27199 27200 +1
+ Misses 7282 7281 -1
Continue to review full report at Codecov.
|
I'd be in favor of adding a "blank" template, for cases which don't neatly fall into one of the categories. For example, #3764 is a bug report / feature request where the user has already identified the root cause of the issue. In that case, I think adding all the environment / steps to reproduce / etc. of the bug report is just unnecessary noise. Of course you can just delete the template once selected, but it creates a mental barrier to doing so. |
Ah, yeah.. guess I missed it because it doesn't get that much screen real estate. Anyway, in that case I think it's fine as is. |
Yes I imagine when any of us open an issue, we will probably just use the blank template, in which case this is unnecessary boiler plate. But for new users I think it could be quite useful, and allows us to also point them towards other places they can look first; like the troubleshooting documentation and the mailing list. |
Is there anyway to test and see what this looks like? In principle I am not opposed but so far we have had very little issues from external users that are not clear enough, so currently I don't feel this is really necessary. This might of course change in the future. I definitely would want that it stays really easy to create issues for ourselves the way we used to, without having to jump through too many hoops. |
I don't know of a way to preview directly on this repo, but as I mention above, this link is a direct replica of what you will see: |
So for us to create an issue we would have an intermediate page where we need to click on one button and then remove the context. This is not too much of a hassle, but I doubt that the benefits really outweigh the downsides for now, simply since it is mostly us creating the majority of issues and we don't really need to be that specific oftentimes |
Yes it's essentially an extra click, but you don't need to remove anything just click on the bottom blank issue link:
I'm not too fussed either way, just wanted to bring it up as a suggestion |
Cheers for that. I think it is not necessary right now, but I don't mind adding it either if others think it is a useful addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of adding one click (and I agree that the 'blank' option is a bit invisible - but people can just delete the text so ok).
But maybe it's ok to make sure people write in the ML if it's just a question, so I'm approving this. Happy for anybody else to merge if at least another person is OK.
OK, in that case we will add it for now. If we get reports that is disturbs more than that it helps, we can remove it |
👍 |
As the title suggests! I have also copied them to this repository, so you can see how they look: https://github.com/chrisjsewell/issues_test/issues/new/choose
closes #4121