-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin ASE, fix test #627
Unpin ASE, fix test #627
Conversation
ca18876
to
52de8b8
Compare
52de8b8
to
272149e
Compare
272149e
to
3f3ed75
Compare
Looks like the failing test is just that new ASE version now prints more digits in the cif file (xyz files are unchanged). Here's the cif file
And here's the diff with the old version diff test.cif test_new.cif
5,9c5,9
< _cell_length_b 3.84737
< _cell_length_c 3.84737
< _cell_angle_alpha 60
< _cell_angle_beta 60
< _cell_angle_gamma 60
---
> _cell_length_b 3.847369863377448
> _cell_length_c 3.847369616935836
> _cell_angle_alpha 59.99999709797012
> _cell_angle_beta 59.999996706409306
> _cell_angle_gamma 59.99999882531759
26,27c26,27
< Si Si1 1.0 0.00000 0.00000 0.00000 1.0000
< Si Si2 1.0 0.25000 0.25000 0.25000 1.0000
---
> Si Si1 1.0 0.0 0.0 0.0 1.0000
> Si Si2 1.0 0.25000000000000006 0.25 0.25 1.0000 |
2bab940
to
0955ea2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 17 17
Lines 3583 3583
=======================================
Hits 2986 2986
Misses 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -105,6 +105,8 @@ def test_structure_data_viewer_storage(structure_data_object): | |||
-1.6859999895095825, -1.6859999895095825, -0.6669999957084656, 1, | |||
] | |||
# fmt: on | |||
# Avoid producing temporary files from povray in the repo | |||
monkeypatch.chdir(tmp_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test produces Si2.png
and __temp__.pov
files so we change the current working directory to a tmp_path. Ultimately this should probably be fixed somewhere in the _render_structure
code. I'll do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Unpin ASE * Fix cif test
fixes #612