Add XPS resource #1071
Merged
Add XPS resource #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
+ Coverage 67.86% 67.91% +0.04%
==========================================
Files 112 113 +1
Lines 6679 6689 +10
==========================================
+ Hits 4533 4543 +10
Misses 2146 2146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
approved these changes
Jan 10, 2025
| class XpsResourceSettingsModel(PluginResourceSettingsModel): | ||
| """Model for the XPS plugin.""" | ||
|
|
||
| title = "XPS Structure" |
There was a problem hiding this comment.
I see, XAS is also XAS Structure. I think it should just be XPS and XAS.
There was a problem hiding this comment.
I removed the structure from the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1070
In the new code resource design, every property plugin needs a resource panel, even if the plugin does not have an additional code other than the
pw.x, as in the XPS plugin.