Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info relaxed structure results tab #1066

Merged

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Jan 8, 2025

This PR closes #928
The displayed information includes the PK, label, description, creation time, and number of atoms.

Structure Creation Details: Knowing when the structure was created and its PK helps users efficiently search for and reuse it in new calculations. The PK also helps to locate the structure within the database.

Interaction with Selection Widget: The number of atoms reminds the user the structure's size (on the tab), enabling them to interact effectively with the selection widget.

image

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (875001a) to head (a5d4021).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pp/result/components/viewer/structure/structure.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   67.88%   67.86%   -0.02%     
==========================================
  Files         112      112              
  Lines        6675     6679       +4     
==========================================
+ Hits         4531     4533       +2     
- Misses       2144     2146       +2     
Flag Coverage Δ
python-3.11 67.86% <50.00%> (+<0.01%) ⬆️
python-3.9 67.88% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes to make the code a bit more consistent with the overall app 🙏

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please remove the redundant comments 🙏

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 0bf982d into aiidalab:main Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RelaxWorkChain Result Tab should display the PK of optimized structure
2 participants