-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info relaxed structure results tab #1066
Add info relaxed structure results tab #1066
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
- Coverage 67.88% 67.86% -0.02%
==========================================
Files 112 112
Lines 6675 6679 +4
==========================================
+ Hits 4531 4533 +2
- Misses 2144 2146 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a few changes to make the code a bit more consistent with the overall app 🙏
src/aiidalab_qe/app/result/components/viewer/structure/structure.py
Outdated
Show resolved
Hide resolved
src/aiidalab_qe/app/result/components/viewer/structure/structure.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please remove the redundant comments 🙏
This PR closes #928
The displayed information includes the PK, label, description, creation time, and number of atoms.
Structure Creation Details: Knowing when the structure was created and its PK helps users efficiently search for and reuse it in new calculations. The PK also helps to locate the structure within the database.
Interaction with Selection Widget: The number of atoms reminds the user the structure's size (on the tab), enabling them to interact effectively with the selection widget.