-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting AddingTag and Periodicity editors #1060
Splitting AddingTag and Periodicity editors #1060
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 67.89% 67.90%
=======================================
Files 112 112
Lines 6659 6664 +5
=======================================
+ Hits 4521 4525 +4
- Misses 2138 2139 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@AndresOrtegaGuerrero why Set this and Set that, departing from the Edit ... "standard"? Also, I find it redundant (in many tabs) where the first thing in the tab is a title that is mostly repeating the tab title. Do we need these? |
Based on the issue #1024 that giovani wrote |
@giovannipizzi why? |
* Introduced a table to display atom coordinates and set the cell tab as the default view. * Implemented a new `TableWidget` class for an interactive and user-friendly table experience. Co-authored-by: Xing Wang <[email protected]>
Suggestion Tab title "Set periodicity" @edan-bainglass what do you think ? |
I think "Edit atom tags" and "Edit periodicity", no titles inside (there's sufficient instructions there). @giovannipizzi is fine with "Edit" instead of "Set". @cpignedoli? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! LGTM! Thanks @AndresOrtegaGuerrero
Perfectly fine with me |
This PR addresses #1024 by splitting the editors of tags and periodicity in separate tabs