Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting AddingTag and Periodicity editors #1060

Conversation

AndresOrtegaGuerrero
Copy link
Member

This PR addresses #1024 by splitting the editors of tags and periodicity in separate tabs

image

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (a1105f1) to head (bb0da2f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/common/widgets.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   67.89%   67.90%           
=======================================
  Files         112      112           
  Lines        6659     6664    +5     
=======================================
+ Hits         4521     4525    +4     
- Misses       2138     2139    +1     
Flag Coverage Δ
python-3.11 67.90% <44.44%> (+<0.01%) ⬆️
python-3.9 67.90% <44.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass
Copy link
Member

edan-bainglass commented Jan 7, 2025

@AndresOrtegaGuerrero why Set this and Set that, departing from the Edit ... "standard"? Also, I find it redundant (in many tabs) where the first thing in the tab is a title that is mostly repeating the tab title. Do we need these?

@AndresOrtegaGuerrero
Copy link
Member Author

@AndresOrtegaGuerrero why Set this and Set that, departing from the Edit ... "standard"? Also, I find it redundant (in many tabs) where the first thing in the tab is a title that is mostly repeating the tab title. Do we need these?

Based on the issue #1024 that giovani wrote

@edan-bainglass
Copy link
Member

@AndresOrtegaGuerrero why Set this and Set that, departing from the Edit ... "standard"? Also, I find it redundant (in many tabs) where the first thing in the tab is a title that is mostly repeating the tab title. Do we need these?

Based on the issue #1024 that giovani wrote

@giovannipizzi why?

* Introduced a table to display atom coordinates and set the cell tab as the default view.
* Implemented a new `TableWidget` class for an interactive and user-friendly table experience.
Co-authored-by: Xing Wang <[email protected]>
@AndresOrtegaGuerrero
Copy link
Member Author

Suggestion
Tab title "Set atom tags"
Text description inside the tab "Assign custom tags to atoms"

Tab title "Set periodicity"
Text description inside the tab "Specify the periodicity of the structure"

@edan-bainglass what do you think ?

@edan-bainglass
Copy link
Member

Suggestion Tab title "Set atom tags" Text description inside the tab "Assign custom tags to atoms"

Tab title "Set periodicity" Text description inside the tab "Specify the periodicity of the structure"

@edan-bainglass what do you think ?

I think "Edit atom tags" and "Edit periodicity", no titles inside (there's sufficient instructions there). @giovannipizzi is fine with "Edit" instead of "Set". @cpignedoli?

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! LGTM! Thanks @AndresOrtegaGuerrero

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit f9d5930 into aiidalab:main Jan 7, 2025
8 checks passed
@cpignedoli
Copy link
Member

Perfectly fine with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants