Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atom table and set cell tab as default #1059

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Jan 6, 2025

Here i am addressing #1050
I am using @superstar54 (He will be co-author of the PR as well) code of TableWidget, with some modifications

Screen.Recording.2025-01-07.at.10.49.26.mov

@AndresOrtegaGuerrero AndresOrtegaGuerrero marked this pull request as ready for review January 7, 2025 09:29
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (94f23c7) to head (a84a994).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pp/result/components/viewer/structure/structure.py 20.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   68.01%   67.90%   -0.11%     
==========================================
  Files         112      112              
  Lines        6634     6659      +25     
==========================================
+ Hits         4512     4522      +10     
- Misses       2122     2137      +15     
Flag Coverage Δ
python-3.11 67.90% <38.46%> (-0.10%) ⬇️
python-3.9 67.91% <38.46%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndresOrtegaGuerrero AndresOrtegaGuerrero changed the title adding table , cell tab as default Add atom table and set cell tab as default Jan 7, 2025
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cosmetics. Other than that, LGTM!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit be88af3 into aiidalab:main Jan 7, 2025
8 checks passed
superstar54 added a commit to superstar54/aiidalab-qe that referenced this pull request Jan 7, 2025
* Introduced a table to display atom coordinates and set the cell tab as the default view.
* Implemented a new `TableWidget` class for an interactive and user-friendly table experience.

---------

Co-authored-by: Xing Wang <[email protected]>
superstar54 added a commit that referenced this pull request Jan 7, 2025
* Introduced a table to display atom coordinates and set the cell tab as the default view.
* Implemented a new `TableWidget` class for an interactive and user-friendly table experience.

---------

Co-authored-by: Xing Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the final results tab with the structure, add a table with coordinates
2 participants