Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guides #1035

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Dec 24, 2024

This PR discards placeholder guide drafts and updates the content of the primary guide draft.

Closes #979

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (5d9ad7e) to head (57e0aa5).

Files with missing lines Patch % Lines
src/aiidalab_qe/common/guide_manager.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   68.98%   68.90%   -0.08%     
==========================================
  Files         113      113              
  Lines        6764     6764              
==========================================
- Hits         4666     4661       -5     
- Misses       2098     2103       +5     
Flag Coverage Δ
python-3.11 68.90% <33.33%> (-0.06%) ⬇️
python-3.9 68.92% <33.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass force-pushed the guide-text branch 2 times, most recently from 690e708 to 2423f64 Compare December 26, 2024 09:01
@edan-bainglass edan-bainglass marked this pull request as ready for review December 26, 2024 09:18
@edan-bainglass edan-bainglass force-pushed the guide-text branch 2 times, most recently from 8307f57 to d796afc Compare December 30, 2024 17:35
Plugin guides
-------------

Plugin developers may introduce additional guides to the app. To do so, add the following key/value entry in your plugin's ``__init__.py`` file:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about , "Plugin developers can enhance the user experience while using the app by introducing custom guides"

"guides": <path-to-guide>,
}

where ``path-to-guide`` is the path (``Path`` object or absolute string path) to the directory containing the guide HTML files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Here, path_to_guide should be either a Path object or an absolute string path pointing to the directory that contains the guide HTML files."

Guide order
-----------

When naming your guide HTML documents, prefix the file name with ``#_``. The number ``#`` will determine the order in which the guides are displayed in the list.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To control the display order of your guide HTML documents, prefix each file name with #_, where # is a number. This number will dictate the order in which the guides appear in the list."

@AndresOrtegaGuerrero
Copy link
Member

Looks good to me , I just had suggestion , but everything looks ready. Feel free to discard suggestions

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edan-bainglass
Copy link
Member Author

Thanks @AndresOrtegaGuerrero. Note that this PR is on hold until we get the main guide text settled on with Giovanni and Carlo. We're meeting today to discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare the text for the in-app-guide
2 participants