json format to check qe is installed or not

aiidalab · Sep 17, 2024 · c2ef7a3 · c2ef7a3
1 parent b9909ba
commit c2ef7a3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/aiidalab_qe/setup/codes.py b/src/aiidalab_qe/setup/codes.py
@@ -44,15 +44,18 @@ def get_qe_env():
 
 
 def qe_installed():
+    import json
+
     env_exist = get_qe_env().exists()
     proc = subprocess.run(
-        ["conda", "list", "-n", f"{get_qe_env().name}", "qe"],
+        ["conda", "list", "-n", f"{get_qe_env().name}", "--json", "--full-name", "qe"],
         check=True,
         capture_output=True,
     )
 
-    # XXX: "qe" in check is not future proof if there are similar packages such as qe-tool, better solution?? JSON output??
-    return env_exist and "qe" in str(proc.stdout)
+    info = json.loads(str(proc.stdout.decode()))[0]
+
+    return env_exist and "qe" == info["name"]
 
 
 def install_qe():