-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial infrastructure #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2aea9b4
to
c8d49c5
Compare
4ad2f91
to
25218ec
Compare
e3b24d6
to
921c634
Compare
0bafb20
to
2cf01eb
Compare
2cf01eb
to
a7db213
Compare
mcgibbon
reviewed
Sep 28, 2023
mcgibbon
reviewed
Sep 28, 2023
mcgibbon
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
ed4f3d5
to
b918d17
Compare
This was referenced Sep 29, 2023
52c1e08
to
a2d8532
Compare
a2d8532
to
842c1a0
Compare
This will allow us to group all the relevant radiative-flux-override changes into a single PR.
Merged
NOAA-GFDL/SHiELD_build#28 and NOAA-GFDL/atmos_drivers#26 have now been merged, which enables us to pin to commits on the |
spencerkclark
added a commit
that referenced
this pull request
Nov 2, 2023
This PR ports the wind transformations added in ai2cm/fv3gfs-fortran#345 to SHiELD-wrapper. Conveniently this did not require any updates to SHiELD that were not already present in #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds an initial working prototype of a Python wrapper of SHiELD:
Changes required to GFDL repositories
There were some minimal changes needed to be made to a couple GFDL-owned repositories:
-fPIC
flag (needed for building the wrapper).public
in the atmos_drivers repository (branch) -- literally a one-line change.These were currently added by pointing the relevant submodules to the appropriate branches on forks. Before merging this PR we should propose / discuss those changes to folks at GFDL and see if we can get those merged into the main public forks first.
Important features currently removed
A few features, which we use in fv3net, were not ported immediately as they require changes to the fortran code, which I prefer to handle on a case-by-case basis. These include: